Are rules supposed to be composable by default?

[thohan88]

In the provided examples, rules appear to be composable when defined in sequence by default:

py-shiny-validate/README.md

Lines 48 to 49 in 757c7cd

	iv.add_rule("email", check.required())
	iv.add_rule("email", check.email())

py-shiny-validate/shiny_validate/examples/2-deffered/app.py

Lines 26 to 27 in 757c7cd

	iv.add_rule("email", check.required())
	iv.add_rule("email", check.email())

However, this does not seem to be the case in practice:

from shiny import App, ui
from shiny_validate import check, InputValidator

app_ui = ui.page_auto(
    ui.input_text("sequential", "Sequential rules"),
    ui.input_text("composed", "Composed rules"),
)


def server(input, output, session):

    set = ["1", "2", ""]

    iv = InputValidator()
    iv.add_rule("sequential", check.required())  # This rule is ignored
    iv.add_rule("sequential", check.in_set(set)) # This rule is enforced
    iv.add_rule("composed", check.compose_rules(check.required(), check.in_set(set)))
    iv.enable()


app = App(app_ui, server)

shinylive

The last rule for for sequential takes precedence here.

[gadenbuie]

Thanks @thohan88! You're right, .add_rule() is intended to add a new rule that's evaluated after previous rules. I just made a change in #14 that should fix this.

If you try it and it gives you any issues please let me know