Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of characters like €, Ä,Ö,Ü,ä,ö,ü #28

Closed
wgemm opened this issue Apr 21, 2024 · 5 comments · Fixed by #29
Closed

Incorrect handling of characters like €, Ä,Ö,Ü,ä,ö,ü #28

wgemm opened this issue Apr 21, 2024 · 5 comments · Fixed by #29

Comments

@wgemm
Copy link

wgemm commented Apr 21, 2024

When I deploy my project with shinylive I get problems with the character handling. This issue was fixed in shiny with the last version. But the webassembly still can't handle it.

Running it with shiny
grafik

Running as webassembly
grafik

@wch
Copy link
Collaborator

wch commented Apr 21, 2024

What platform are you deploying from? If it is Windows, I have an idea of what might be going on.

@wgemm
Copy link
Author

wgemm commented Apr 21, 2024

I am deploying from Windows 10

@wch wch mentioned this issue Apr 23, 2024
@wch
Copy link
Collaborator

wch commented Apr 23, 2024

I made a potential fix in #29.

Does it work if you install with the following command and then deploy again?

pip install git+https://github.com/posit-dev/py-shinylive.git@windows-encoding --force-reinstall

@wgemm
Copy link
Author

wgemm commented Apr 23, 2024

Thanks a lot. I have tested the branch. The version works fine for me!

@wch
Copy link
Collaborator

wch commented Apr 23, 2024

Great!

@wch wch closed this as completed in #29 Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants