-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What would I need to add this to CactEye #20
Comments
I added the following patch to the CactEye mod, and am getting endless Nullrefs: `@PART[tele_body,tele_body2]:NEEDS[SpaceDust]
} @part[tele_body]:NEEDS[SpaceDust]
} @part[tele_body2]:NEEDS[SpaceDust]
} ` |
Uh that's the right approach. Maybe you can post the final cached patched version of the config and the full log? There may be an initialization error. |
Of course, now that I went to get you the info, it works perfectly :-( I'd like to leave this open for a bit, so that if it happens again I can just add to this. I'll close it in a few days if it doesn't come back. May have been a "funny" in the test install I was using |
Ok, in my latest test, got the null refs I mentioned before. Part with the dust telescope is: CactEye/Parts/tele_body/tele_body.cfg |
I traced the problem to the fact that the scanState seems to be uninitialized at the following line: https://github.com/ChrisAdderley/SpaceDust/blob/659416c9e1a8c381ff6d1bdc9e03a2be4eaba771/Source/SpaceDust/Modules/ModuleSpaceDustTelescope.cs#L309 |
Ok, so I found the following: First error occured right after switching to the flight scene, here: The problem is in SpaceDustInstruments, the GetInstrument(string name), I found that Instruments is null. I have a dev environment for it, so if you want to have me try something, just let me know. All I've done so far is add Debug.Log statements to trace where the exception is happening. Hope this helps |
For the record adding the following code right after GetInstrument(string name), in SpaceDustInstruments.cs, after line 34, fixed it. Not a recommended fix, it's just a patch to see if it is just an initialization problem: |
The thing that's confusing me is that last I checked everything was fine with my parts, so I need to take some time to investigate this in your context. |
ok. I just pushed everything, and here is a beta release if you need it to test |
I wonder if it could be the order of the modules in the config? |
Not sure. I'm working on other projects right now but I will investigate this when I get a chance (maybe tomorrow night, maybe tonight) |
I made a new release that added the initialization change you made - it seems like a good move. |
Thank you. |
Hi, Just tested. Seems that the release doesn't include that fix, I still got the error. So I looked at the dll using ILSpy, the fix isn't in there. LGG |
Huh, I'll look in more detail when I have a moment. |
I installed that zip you added above to try to test and unfortunately couldn't - on placing the cacteye large telescope in the VAB log got flooded with errors related to CactEyeGUI. See log: |
I assume that if I copy these lines:
https://github.com/ChrisAdderley/SpaceDust/blob/659416c9e1a8c381ff6d1bdc9e03a2be4eaba771/GameData/SpaceDust/Parts/Scanning/spacedust-telescope-1.cfg#L41-L298
and add them to the two CactEye telescopes (using a MM patch)
and then change the following to match the telescope:
that is al that would be needed?
The text was updated successfully, but these errors were encountered: