Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers disappear when another tab is being used. #1

Open
sorrynoobsitsme opened this issue Aug 26, 2024 · 7 comments
Open

Numbers disappear when another tab is being used. #1

sorrynoobsitsme opened this issue Aug 26, 2024 · 7 comments

Comments

@sorrynoobsitsme
Copy link

Description.
A clear and concise description of what the bug is.

Steps to reproduce the bug.

  1. Load the page and immediately open another tab.
  2. After about 30 seconds, switch back to the start page.
  3. Repeat as necessary.

Expected behavior.
I would expect the time to show the numbers even if another tab is currently in the foreground.

Screenshots.
Screenshot 2024-08-25 at 10 16 50 PM
Screenshot 2024-08-25 at 10 17 04 PM

System.

  • Device: Desktop Mac.
  • OS: MacOS 15.0 Beta 24A5289h.
  • Browser: Chrome.
  • Version 127.0.6533.120 (Official Build) (arm64).

Additional context.
Add any other context about the problem here.

@pprmint
Copy link
Owner

pprmint commented Aug 26, 2024

I'm aware of this one. It seems to be an issue with React-Spring #1954 in combination with the exitBeforeEnter prop used on the digit transitions in certain digital clocks.

I need to figure out a way to make these animations work without that particular prop. The reason why I'm using it is because otherwise you'd end up with two digits briefly appearing next to each other, one entering and one exiting, which causes an ugly horizontal shift.

@sorrynoobsitsme
Copy link
Author

I'm aware of this one. It seems to be an issue with React-Spring #1954 in combination with the exitBeforeEnter prop used on the digit transitions in certain digital clocks.

I need to figure out a way to make these animations work without that particular prop. The reason why I'm using it is because otherwise you'd end up with two digits briefly appearing next to each other, one entering and one exiting, which causes an ugly horizontal shift.

This might be a really janky solution but, if it causes a horizontal shift then maybe try rotating both the font and element 90 degrees?

@pprmint
Copy link
Owner

pprmint commented Aug 26, 2024

...no. The issue is that the incoming digit will appear alongside the then-current digit while they both play their animation.

12:34:56
12:34:567 (6 fades out, 7 fades in next to it)
12:34:57 (both finished their transition)
12:34:578 (repeat)

@WumpusNitro
Copy link

yea it's annoying. but i hope it gets patched soon

@sorrynoobsitsme
Copy link
Author

image
I don't know if its the same issue with react-spring but this has started to occur

pprmint added a commit that referenced this issue Dec 6, 2024
Accidentally pushed an attempt at fixing #1.
@pprmint
Copy link
Owner

pprmint commented Dec 6, 2024

Sorry about that. When I removed Inquest from the search engine list I accidentally included the changes I made to the default clock in an attempt to fix this issue.

To no avail so far, btw.

@sorrynoobsitsme
Copy link
Author

sorrynoobsitsme commented Dec 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants