Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preact throws with @material-ui/data-grid #3055

Closed
jschill opened this issue Mar 10, 2021 · 3 comments
Closed

Preact throws with @material-ui/data-grid #3055

jschill opened this issue Mar 10, 2021 · 3 comments

Comments

@jschill
Copy link

jschill commented Mar 10, 2021

Reproduction

https://codesandbox.io/s/busy-bash-qxfs0

Steps to reproduce

JS error on page load

Expected Behavior

The above code is copy/paste from their example:
https://material-ui.com/components/data-grid#mit-version

Actual Behavior

TypeError: i.current.getLocaleText is not a function

That error is referencing to this LOC:
https://github.com/mui-org/material-ui-x/blob/c179435dbd6a2cf365347b8e555de3271187e2f5/packages/grid/_modules_/grid/components/containers/GridRoot.tsx#L31

@mapringg
Copy link

Having the same problem. What can I do besides forking and adjusting @material-ui/data-grid?

@oliviertassinari
Copy link

oliviertassinari commented Jun 3, 2021

While we support Preact for MUI Core, the support of Preact might be challenging for MUI X. It feels that we rely more on how React behaves than in the core.

We might look into it in the future. Bundle size matters, and it could even be important for us if we need to expose an Angular or Vue wrapper with Preact.

@rschristian
Copy link
Member

Going to close this out in favor of #4344, which tracks an issue with a more modern version of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants