Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Card into two components: Surface and Card #76

Open
CarlosBalladares opened this issue Jul 14, 2022 · 0 comments
Open

Refactor Card into two components: Surface and Card #76

CarlosBalladares opened this issue Jul 14, 2022 · 0 comments
Assignees
@CarlosBalladares
Labels
@premail/components belongs to premail components pkg refactor refactoring production code, eg. renaming a variable
Milestone
Design and app ba...

Comments

@CarlosBalladares
Copy link
Contributor

Surface components should be an unopinionated component for content.

Card should be an opinionated component to present content in a specific format.
@CarlosBalladares CarlosBalladares added refactor refactoring production code, eg. renaming a variable @premail/components belongs to premail components pkg labels Jul 14, 2022
@CarlosBalladares CarlosBalladares self-assigned this Jul 14, 2022
@CarlosBalladares CarlosBalladares moved this to In Progress in Premail editor Jul 14, 2022
@CarlosBalladares CarlosBalladares mentioned this issue Jul 16, 2022
Merged
CarlosBalladares added a commit that referenced this issue Jul 16, 2022
@CarlosBalladares
♻️ refactor: Rename Card to Surface (#85)
d00bbc1 
* Renamed Card to Surface
* Improve testing coverage
* Extend storybook

This partially implements #76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarlosBalladares CarlosBalladares

Labels
@premail/components belongs to premail components pkg refactor refactoring production code, eg. renaming a variable
Projects
Premail editor
Status: No status
Milestone
Design and app base, MVP
Development

No branches or pull requests
1 participant
@CarlosBalladares