Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Increase spacing between CTA buttons #903

Open
simurai opened this issue Jan 23, 2025 · 1 comment · May be fixed by #909
Open

[Suggestion] Increase spacing between CTA buttons #903

simurai opened this issue Jan 23, 2025 · 1 comment · May be fixed by #909
Assignees
@danielguillan
Labels
brand

Comments

@simurai
Copy link
Contributor

simurai commented Jan 23, 2025 •
edited
Loading

Problem

Currently the buttons of the CTABanner have a spacing of 8px:

Buttons with a gap of 8px

Suggestion

Increase the spacing to 16px.

Notes

I think we recently did the same for the Hero actions. So maybe this should be the new default for ButtonGroup which I think is used by CTABanner.

This came up in https://github.com/orgs/github/projects/19513/views/2?pane=issue&itemId=81967978. /cc @jesussandreas
@rezrah
Copy link
Collaborator

rezrah commented Jan 27, 2025 •
edited
Loading

Triaged during planning. Site design confirmed that Hero should be added to scope of this change.

@danielguillan danielguillan linked a pull request Jan 28, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielguillan danielguillan

Labels
brand
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase and standardize button group gap primer/brand
4 participants
@danielguillan @simurai @joshfarrant @rezrah