Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

182 remove the old doenrolltoken function #184

Merged
merged 9 commits into from
Sep 19, 2023

Conversation

lukasmatusiewicz
Copy link
Contributor

@lukasmatusiewicz lukasmatusiewicz commented Feb 9, 2023

Wait some time with merging.

@lukasmatusiewicz lukasmatusiewicz linked an issue Feb 9, 2023 that may be closed by this pull request
@nilsbehlen nilsbehlen removed their request for review February 9, 2023 12:32
Copy link
Member

@nilsbehlen nilsbehlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it not used somewhere in the code anymore?

@lukasmatusiewicz
Copy link
Contributor Author

sorry, didn't check it now.

<?php
// If enrollToken load QR Code
if (isset($this->data['tokenQR']))
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where will the qr code from enroll via multichallenge be placed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in one of the image inputs. message also comes from the server and this extra fields isn't needed anymore.

@nilsbehlen nilsbehlen merged commit 0494279 into master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the old "doEnrollToken" function
2 participants