-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skore.show_activity() a simple helper function to get users started #1002
Comments
To me it seems like exposing the current |
Let's start a discussion about the scope of functionality here. @MarieS-WiMLDS provides her views on the feature in #1194 (review)
@GaelVaroquaux mentioned his wishes as:
On this I would wish the same feature as @GaelVaroquaux. #1157 added a parameter to # explicitely passing create, overwrite, and server but there are the actual
# default values
project = skore.open("project.skore", create=True, overwrite=False, serve=True)
project.put(...) # live interaction in the started server above In addition to the incentive that @GaelVaroquaux mentioned, I foresee 2 comparable UX that I pretty much like:
The fact that I'm expecting NB: #1194 makes it easier to deal with the |
Update in my thoughts: given that now we are starting a project with a init directly and not a function, we can add a new function which main purpose is to launch an UI, and which may (not convinced yet, but not so opposed) happen to create a project on the way if it doesn't exist yet. |
@MarieS-WiMLDS I completely agree. It is not what I proposed. Basically, we associate a server to a project by setting server_info = launch_server()
skore.Project(path="project_name", server-ui=server_info) But I really think that a user should not have to deal with this low level stuff. Those actions should happen under the hood (and it is the purpose of the function). In pseudo code, it would be def open(path="project_name", server=True):
project = skore.Project(path=path)
if serve:
server_info = launch_server(project=project)
project._server_info = server_info |
This seems great! I'm setting this issue as ready since it seems that we are reaching a cool solution! |
🎉 |
Is your feature request related to a problem? Please describe.
As mentioned in #1001 , we need to bridge the skore notions of store, activity feed, UI, to the way many data scientists currently work: interactive work in vscode and jupyter notebooks.
Getting immediate benefits of skore requires setting up a project, and opening a web browser. This is a central sequence of operation that we can expect users to be doing over and over.
It requires knowing (and remembering) that "skore launch project_name" must be run.
It requires to open a shell, and run the corresponding command, in the right python environment. Shell commands and Python environment mess is a place where it is easy to loose users.
Describe the solution you'd like
I would like a small function to do all this for me.
Short term, it helps getting people started (eg by inserting it in every one of our example) and stupid mistakes. In the long term, we can insert more cleverness (like detecting that we are on a compute cluster and not actually starting a web browser there :) , avoid starting multiple browsers for the same project on the same computer, potentially closing the server at the exit of the Python executable where it was started, to avoid pollution of servers).
Unlike
skore.create
,skore.show_activity
should by default:The text was updated successfully, but these errors were encountered: