Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment requests should be ordered #99

Open
guseggert opened this issue Jan 11, 2023 · 2 comments
Open

Experiment requests should be ordered #99

guseggert opened this issue Jan 11, 2023 · 2 comments

Comments

@guseggert
Copy link

guseggert commented Jan 11, 2023

IIUC, each experiment gets its own SQS queue. Standard queues are sometimes ordered, but not always. To preserve order when replaying traffic, we should use FIFO queues (or Kinesis streams?). This would also prevent duplicate messages.

@iand
Copy link
Contributor

iand commented Jan 11, 2023

All targets in an experiment get the requests in the same order since dealgood reads from the queue sequentially and sends that request to each target (or drops it if the target is overloaded). So in a single experiment all nodes see the same sequence of requests. However another independent experiment may see a different ordering.

@guseggert
Copy link
Author

Yes but SQS queues themselves do not guarantee order unless they are FIFO queues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants