Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

Hook up to merge bot #210

Open
jlebon opened this issue Jul 20, 2017 · 1 comment
Open

Hook up to merge bot #210

jlebon opened this issue Jul 20, 2017 · 1 comment

Comments

@jlebon
Copy link
Contributor

jlebon commented Jul 20, 2017

We should hook up homu to this repo. The issue with "Squash and merge" is that you lose the semantics of separate commits and have a non-sensical commit msg that joins all the msgs. Commit msgs from fixup! commits also get in, which is yucky.

Let's install a basic testsuite that homu can gate on (I'm ignoring the existing PR tests we have now since as I mentioned before, it's conceptually not really appropriate for gating PRs). And from there, hook up homu.

@miabbott
Copy link
Collaborator

Homu all the things!

Not opposed to this, but would like input on ideas on how to gate on PRs. We were working toward something a little more intelligent in our PAPR tests, but still have work to do in that space.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants