Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Clarify chart is not 100% faithful to kube-prometheus #4741

Closed
d4nyll opened this issue Jul 25, 2024 · 1 comment · Fixed by #5113
Closed

[kube-prometheus-stack] Clarify chart is not 100% faithful to kube-prometheus #4741

d4nyll opened this issue Jul 25, 2024 · 1 comment · Fixed by #5113
Labels
enhancement New feature or request

Comments

@d4nyll
Copy link

d4nyll commented Jul 25, 2024

Is your feature request related to a problem ?

Based on the name of the chart kube-prometheus-stack and the first line of the README.md:

Installs the kube-prometheus stack...

It gives the impression that the chart will install everything in the list in the kube-prometheus README.md, namely:

Components included in this package:

However, kube-prometheus-stack does not include the Prometheus Adapter nor blackbox-exporter, but does include prometheus-windows-exporter.

Describe the solution you'd like.

Change the README.md to be explicit about these caveats.

Describe alternatives you've considered.

Rename the chart to dissociate itself from kube-prometheus

Additional context.

It can avoid issues like #1974 where someone expects Prometheus Adapter to be installed when, in reality, it isn't.

@d4nyll d4nyll added the enhancement New feature or request label Jul 25, 2024
@jkroepke
Copy link
Member

Would you iike to create an PR here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants