diff --git a/prometheus-metrics-exposition-formats/src/test/java/io/prometheus/metrics/expositionformats/ExpositionFormatsTest.java b/prometheus-metrics-exposition-formats/src/test/java/io/prometheus/metrics/expositionformats/ExpositionFormatsTest.java index 1e5e1ade9..7b4a6ef0b 100644 --- a/prometheus-metrics-exposition-formats/src/test/java/io/prometheus/metrics/expositionformats/ExpositionFormatsTest.java +++ b/prometheus-metrics-exposition-formats/src/test/java/io/prometheus/metrics/expositionformats/ExpositionFormatsTest.java @@ -1869,7 +1869,6 @@ public void testFindWriter() { writer = expositionFormats.findWriter(acceptHeaderValue); Assert.assertEquals(expectedFmt, writer.getContentType() + escapingScheme.toHeaderFormat()); - // TODO review if this is ok nameEscapingScheme = EscapingScheme.VALUE_ENCODING_ESCAPING; // OM format, no version diff --git a/prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/PrometheusNamingTest.java b/prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/PrometheusNamingTest.java index 16d66954e..432481e45 100644 --- a/prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/PrometheusNamingTest.java +++ b/prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/PrometheusNamingTest.java @@ -120,7 +120,6 @@ public void testEscapeName() { got = unescapeName(got, EscapingScheme.VALUE_ENCODING_ESCAPING); Assert.assertEquals("no:escaping_required", got); - // TODO should add test for legacy validation? // name with dots got = escapeName("mysystem.prod.west.cpu.load", EscapingScheme.UNDERSCORE_ESCAPING); Assert.assertEquals("mysystem_prod_west_cpu_load", got);