From 2a8efae111e1b992a2e0b45b0c2ba99259fe070e Mon Sep 17 00:00:00 2001 From: Jason Lunn Date: Thu, 18 Apr 2024 13:22:13 -0400 Subject: [PATCH] Evaluate a fix for FFI --- .github/workflows/test_ruby.yml | 12 ++++-------- ruby/Gemfile | 2 ++ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/workflows/test_ruby.yml b/.github/workflows/test_ruby.yml index b858bbfcda8af..1f90b55c77fb8 100644 --- a/.github/workflows/test_ruby.yml +++ b/.github/workflows/test_ruby.yml @@ -20,13 +20,11 @@ jobs: # Test both FFI and Native implementations on the highest and lowest # Ruby versions for CRuby and JRuby, but only on Bazel 5.x. - { name: Ruby 3.0, ruby: ruby-3.0.2, ffi: NATIVE } - # TODO Re-enable these once flakes are fixed - #- { name: Ruby 3.0, ruby: ruby-3.0.2, ffi: FFI } + - { name: Ruby 3.0, ruby: ruby-3.0.2, ffi: FFI } - { name: Ruby 3.1, ruby: ruby-3.1.0 } - { name: Ruby 3.2, ruby: ruby-3.2.0 } - { name: Ruby 3.3, ruby: ruby-3.3.0, ffi: NATIVE } - # TODO Re-enable these once flakes are fixed - #- { name: Ruby 3.3, ruby: ruby-3.3.0, ffi: FFI } + - { name: Ruby 3.3, ruby: ruby-3.3.0, ffi: FFI } - { name: JRuby 9.4, ruby: jruby-9.4.6.0, ffi: NATIVE } - { name: JRuby 9.4, ruby: jruby-9.4.6.0, ffi: FFI } @@ -116,13 +114,11 @@ jobs: # Ruby versions for CRuby, but only on Bazel 5.x. # Quote versions numbers otherwise 3.0 will render as 3 - { version: "3.0", ffi: NATIVE } - # TODO Re-enable these once flakes are fixed - #- { version: "3.0", ffi: FFI } + - { version: "3.0", ffi: FFI } - { version: "3.1" } - { version: "3.2" } - { version: "3.3", ffi: NATIVE } - # TODO Re-enable these once flakes are fixed - #- { version: "3.3", ffi: FFI } + - { version: "3.3", ffi: FFI } name: MacOS Ruby ${{ matrix.version }}${{ matrix.ffi == 'FFI' && ' FFI' || '' }} runs-on: macos-12 diff --git a/ruby/Gemfile b/ruby/Gemfile index fa75df1563230..13af89b10dfb9 100644 --- a/ruby/Gemfile +++ b/ruby/Gemfile @@ -1,3 +1,5 @@ source 'https://rubygems.org' +gem :ffi, github: 'KJTsanaktsidis/ffi', branch: 'missing_wb_struct_layout' + gemspec