Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor approval status comparators #831

Open
ajkiessl opened this issue Aug 26, 2024 · 0 comments
Open

Refactor approval status comparators #831

ajkiessl opened this issue Aug 26, 2024 · 0 comments

Comments

@ajkiessl
Copy link
Contributor

Anywhere we do a committee status or head of program status (from ApprovalStatus) comparison, we should be using the constants in ApprovalStatus:

APPROVED_STATUS = 'approved'
REJECTED_STATUS = 'rejected'
PENDING_STATUS = 'pending'
NONE_STATUS = 'none'

It would be even better to refactor these comparisons into a single method like approved?, rejected?, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant