Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock controller test with external call #1668

Open
ajkiessl opened this issue Jan 17, 2025 · 0 comments
Open

Mock controller test with external call #1668

ajkiessl opened this issue Jan 17, 2025 · 0 comments

Comments

@ajkiessl
Copy link
Collaborator

Here:

RSpec.describe Dashboard::CollectionsController, type: :controller do
# TODO this appears to call identity API, we should mock this out
# This was Adams access account. he left. tests started failing.
let(:valid_attributes) {
{
'editors_form' => {
'edit_users' => ['djb44']
}
}
}

We need to mock this or it fails when the user leaves Penn State. Tests shouldn't be making external calls like this anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant