Add post_replies source in user stream #239
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirRamirfatahi
changed the title
SHAcollision
requested changes
Jan 2, 2025
Comment on lines
+271
to
+272
| let post_id = post_id.unwrap(); | ||
| let author_id = author_id.unwrap(); |
There was a problem hiding this comment.
Needs proper handling instead of unwrap()
let post_id = post_id.ok_or_else(|| {
anyhow!("Post ID should be provided for user streams with source 'post_replies'")
})?;
let author_id = author_id.ok_or_else(|| {
anyhow!("Author ID should be provided for user streams with source 'post_replies'")
})?;
Comment on lines
+288
to
+298
| let unique_user_ids: HashSet<String> = replies | ||
| .map(|replies| { | ||
| replies | ||
| .into_iter() | ||
| .map(|reply| reply.0.split(":").next().unwrap().to_string()) | ||
| .collect::<Vec<String>>() | ||
| }) | ||
| .into_iter() | ||
| .flatten() | ||
| .collect(); | ||
| Some(unique_user_ids.into_iter().collect()) |
There was a problem hiding this comment.
Avoid unwrap()
Untested, maybe something like.
let unique_user_ids: HashSet<String> = replies
.map(|replies_batch| {
replies_batch
.into_iter()
.filter_map(|(raw_id, _some_other_data)| {
// Split on ":" and take the first piece; avoid `unwrap()`
raw_id.split(':').next().map(ToString::to_string)
})
.collect::<Vec<String>>()
})
.flatten()
.collect();
Comment on lines
+270
to
+299
| UserStreamSource::PostReplies => { | ||
| let post_id = post_id.unwrap(); | ||
| let author_id = author_id.unwrap(); | ||
| let key_parts = [ | ||
| &POST_REPLIES_PER_POST_KEY_PARTS[..], | ||
| &[author_id.as_str(), post_id.as_str()], | ||
| ] | ||
| .concat(); | ||
| let replies = PostStream::try_from_index_sorted_set( | ||
| &key_parts, | ||
| None, | ||
| None, | ||
| None, | ||
| None, | ||
| SortOrder::Descending, | ||
| None, | ||
| ) | ||
| .await?; | ||
| let unique_user_ids: HashSet<String> = replies | ||
| .map(|replies| { | ||
| replies | ||
| .into_iter() | ||
| .map(|reply| reply.0.split(":").next().unwrap().to_string()) | ||
| .collect::<Vec<String>>() | ||
| }) | ||
| .into_iter() | ||
| .flatten() | ||
| .collect(); | ||
| Some(unique_user_ids.into_iter().collect()) | ||
| } |
There was a problem hiding this comment.
Too much logic inside of this arm of the match statement.
We should do the same as for the UserStreamSource::Recommended arm. Move the logic to a new get_post_replies_ids(post_id: &str, author_id: &str) -> Result<Option<Vec<String>>, DynError> function.
Please use the keyword |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #228
Pre-submission Checklist
cargo test.cargo bench