Take account of maximumDelay in LinearRetryPolicy #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given the @are |
mohitpubnub
added a commit
that referenced
this pull request
Dec 9, 2024
Fixed issue pointed out by PR #127 for limiting retry delay within maximum delay for linear policy
|
@Ali-Toosi Thank you for your findings and efforts in creating this PR. We will be consolidating these changes into the upcoming release to ensure a more comprehensive changelog and to align with our release process. As merging this PR directly cause lack of changes information! |
mohitpubnub
added
status: accepted
Merged
mohitpubnub
added a commit
that referenced
this pull request
Dec 10, 2024
* * `custom_message_type` support for subscription, publish, signal and files features. * `custom_message_type` field parsing support in history apis. * acceptance tests steps implementation for custom_message_type * set default retry policy to `Exponential` with default configuration. Fixed issue pointed out by PR #127 for limiting retry delay within maximum delay for linear policy * fix: linting and warnings * fix channel test for customMessageType * PubNub SDK v5.0.0 release. * update changelog --------- Co-authored-by: PubNub Release Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the linear retry policy is not being limited by the maximumDelay. This fixes it, following how exponential retry handles the maximum delay.