Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription manager should respond with complete PNStatus #136

Open
gvaibhav1734 opened this issue Sep 26, 2022 · 0 comments
Open

Subscription manager should respond with complete PNStatus #136

gvaibhav1734 opened this issue Sep 26, 2022 · 0 comments

Comments

@gvaibhav1734
Copy link

gvaibhav1734 commented Sep 26, 2022

PNStatus not populated completely

res, _, err := executeRequest(opts)

Why are we ignoring the PNStatus returned by executeRequest here?

executeRequest has full context of the API response and returns a fully populated PNStatus which is ignored and it is then being recreated minimally with only PNStatus.Category information.

Solution

We should either be passing the returned response from executeRequest or construct the PNStatus fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant