Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs package: right-clicking on a tab does not add a right-clicked class #349

Closed
5 tasks done
savetheclocktower opened this issue Jan 27, 2023 · 2 comments · Fixed by #368
Closed
5 tasks done

Tabs package: right-clicking on a tab does not add a right-clicked class #349

savetheclocktower opened this issue Jan 27, 2023 · 2 comments · Fixed by #368
Labels
bug Something isn't working

Comments

@savetheclocktower
Copy link
Contributor

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

This pull request made it so that right-clicking on a tab no longer adds a right-clicked class. The author notes that they regarded this behavior to be “unused,” but the Zentabs package relies on this behavior for its “Pin tab” and “Unpin tab” commands. It uses .right-clicked to identify which tab was right-clicked and trace it back to its associated editor pane.

I'm treating this as a bug because Pulsar allows a package to add commands to a tab's context menu, which means that those commands need some way to figure out which tab they were invoked from. There's no other obvious way that I can see, and if Pulsar restores the .right-clicked behavior, it will fix Zentabs (and other packages, probably) without their needing to push out an update.

I will be happy to contribute this fix myself if need be, but I'm opening this issue because I've not yet set up my local environment to do so.

Pulsar version

1.101.0-beta

Which OS does this happen on?

🍎 macOS

OS details

11.7.2

Which CPU architecture are you running this on?

64-bit(x86_64)

What steps are needed to reproduce this?

  1. Open the inspector and inspect a tab element.
  2. Right-click on that tab.
  3. Observe that no classes are added to the li element that represents the tab.

Additional Information:

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@savetheclocktower and others