Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Upstream provider causing confluent provider to show username and password in terminal #2

Closed
pierskarsenbarg opened this issue Jun 25, 2021 · 4 comments · Fixed by #8
Assignees
Labels
impact/security kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone

Comments

@pierskarsenbarg
Copy link
Member

Underlying TF provider issue causes username and password to show up in terminal via stderr.

The underlying cause is the Confluent SDK uses by the Terraform provider (https://github.com/Mongey/terraform-provider-confluentcloud) hard codes the debug level of HTTP requests responses to true. There's a PR that fixes it https://github.com/cgroschupp/go-client-confluent-cloud/pull/22.
@pierskarsenbarg pierskarsenbarg added the kind/bug Some behavior is incorrect or out of spec label Jun 25, 2021
@aviflax
Copy link

aviflax commented Jul 9, 2021

The security problem is obviously a big deal, but I just want to add that the fact that the provider is writing a ton of debug messages to stderr means that when I use the provider by running pulumi up — dozens or hundreds of lines of text are written to my terminal in the “diagnostics” section, which is distracting and a bit annoying.

@raytung
Copy link

raytung commented Jul 15, 2021

This happens due to the Terraform provider using a Confluent SDK which hard coded debug output to true. This can be tracked in cgroschupp/go-client-confluent-cloud#22. There's also an issue in the Terraform provider to bump the SDK Mongey/terraform-provider-confluentcloud#88.

@treykasada
Copy link
Contributor

Mongey/terraform-provider-confluentcloud#88 has now been resolved and the fix released. We should just be able to resolve this by bumping the version used here to that latest release. 🙂

@treykasada
Copy link
Contributor

I've raised a PR to bump the version. I believe it needs more work before it can be merged, but I was unable to get make to run. If someone can lend a hand and/or takeover from here, that'd be swell! 🙂

@stack72 stack72 closed this as completed in #8 Aug 4, 2021
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Aug 4, 2021
@stack72 stack72 added this to the 0.60 milestone Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/security kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
7 participants