Gems installs broken since about 2.6.0.0

[billglick]

Describe the Bug

Starting around 2023-01-19 (presumably with PDK Docker image 2.6.0.0 ) the PDK docker image does not have make or gcc packages and so gem install fails (when pdk attempts to install dependencies).

Expected Behavior

Prior to this we could gem install dependencies.

Steps to Reproduce

TBD

Environment

• Version: 2.6.1.0
• Platform: ubuntu-latest

Additional Context

We run into this when running the puppets-epic-show-theatre/action-pdk-validate GitHub action. We originally thought it was an issue with that action, but it seems to be due to a change of either the PDK and/or ubuntu-latest Docker images.

We are able to work around this by installing build-essential package group in the container and then the pdk validate succeeds.

[chelnak]

Hello!

Could you kindly build and test the image in this pr?

This is something we are currently investigating.

Installing build-essential does fix the issue but also bumps the size of the image higher than i'd like.

[billglick]

@chelnak That sounds very promising.

Unfortunately I do not know how to build and test an image from a pull request. Is there a standard process that I could follow to do that?

[andylytical]

@chelnak pdk still fails with #42

Working with @billglick, here's the steps to reproduce (and also to verify the workaround): https://github.com/andylytical/pdktest

[chelnak]

Thanks, I'll take a look.

[chelnak]

I think your issue might be pdk-templates here.

I noticed that the module you use as an example is pinned to pdk-templates 2.5.0.

There were some significant changes with gems between 2.5 and 2.6.

After running pdk update --force in your module I was able to perform a successful validation.

Can you give this a try?

[fraenki]

I can confirm that updating an affected module to the latest PDK fixed this issue.

However, it's still sad that backwards-compatibility is broken. So I've tried the latest puppet/pdk:nightly image, hoping that it would allow me to use older versions of PDK for the time being, but it fails with the same error.

Is this image expected to contain the fix? It was build at around the same time PR #42 was merged, so I thought I should give it a try. :)

[chelnak]

So #42 really just updates the base image and ensures that we have some dependencies available.

It sounds like you could just pull the 2.5 tag here though?

https://hub.docker.com/layers/puppet/pdk/2.5.0.0/images/sha256-87ed6a61199feb968cf0f53302c6c94e93170a4c193b0e6f945c3e3c01bbbbd2?context=explore

[fraenki]

It sounds like you could just pull the 2.5 tag here though?

Sure. :) I wanted to avoid that, so that it doesn't break when I'm actually upgrading my modules to PDK >= 2.6... but yes, it's a valid workaround.

[chelnak]

Yeah so I think this is a limitation of the docket container.

You'd have to upgrade on a module by module basis.

[andylytical]

I confirmed this fixes the issue!

@billglick do you agree?

[andylytical]

@chelnak Feel free to close this issue.

[chelnak]

Thank you 🙏