You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe the poolmetadatasize parameter should be allowed to be a string such as '10M'
If it must be an integer and not a string, the rspec test should be updated.
Our own rspec tests fail if we set the poolmetadatasize, with
'parameter 'poolmetadatasize' expects a value of type Undef or Integer, got String'
Expected Behavior
Parameter documentation, rspec tests and parameter types are consistent.
Describe the Bug
I believe the poolmetadatasize parameter should be allowed to be a string such as '10M'
If it must be an integer and not a string, the rspec test should be updated.
Our own rspec tests fail if we set the poolmetadatasize, with
'parameter 'poolmetadatasize' expects a value of type Undef or Integer, got String'
Expected Behavior
Parameter documentation, rspec tests and parameter types are consistent.
Steps to Reproduce
poolmetadatasize parameter is set to be an integer:
https://github.com/puppetlabs/puppetlabs-lvm/blob/v2.1.0/manifests/logical_volume.pp#L77
but in rspec test, a poolmetadatasize of '10M' is used:
https://github.com/puppetlabs/puppetlabs-lvm/blob/v2.1.0/spec/unit/puppet/type/logical_volume_spec.rb#L18
Environment
The text was updated successfully, but these errors were encountered: