From bad7af8f6af6fa9214c2533ca9f21b6091802f69 Mon Sep 17 00:00:00 2001 From: Santhosh <52504160+santacodes@users.noreply.github.com> Date: Wed, 12 Jun 2024 14:30:27 +0530 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Arjun Verma --- .github/test_on_push.yml | 4 +++- tests/test_project_generation.py | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/test_on_push.yml b/.github/test_on_push.yml index f052dfd..edc07bd 100644 --- a/.github/test_on_push.yml +++ b/.github/test_on_push.yml @@ -3,7 +3,9 @@ name: pybamm_cookiecutter on: workflow_dispatch: pull_request: - push: [main] + push: + branches: + - main jobs: style: runs-on: ubuntu-latest diff --git a/tests/test_project_generation.py b/tests/test_project_generation.py index e2e40f0..d87aa56 100644 --- a/tests/test_project_generation.py +++ b/tests/test_project_generation.py @@ -24,7 +24,7 @@ def test_bake_custom_project(cookies: Cookies, custom_template): Testing if the projects exists in the tempdir """ result = cookies.bake(template=str(custom_template)) - assert result.exit_code == 0, "Exited with code 0" + assert result.exit_code == 0, f"Exited with code {result.exit_code}, expected 0" assert result.exception is None, result.exception assert result.project_path.name == "pybamm_cookie" - assert result.project_path.is_dir(), "Project directory not found" + assert result.project_path.is_dir(), f"Project directory {result.project_path} not found"