Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_open_nczarr failing #7572

Closed
headtr1ck opened this issue Feb 28, 2023 · 3 comments · Fixed by #7575
Closed

test_open_nczarr failing #7572

headtr1ck opened this issue Feb 28, 2023 · 3 comments · Fixed by #7575
Labels
topic-testing topic-zarr Related to zarr storage library

Comments

@headtr1ck
Copy link
Collaborator

What is your issue?

In the latest CI runs it seems that test_backends.py::TestNCZarr::test_open_nczarr is failing with

KeyError: 'Zarr object is missing the attribute _ARRAY_DIMENSIONS and the NCZarr metadata, which are required for xarray to determine variable dimensions.'

I don't see an obvious reason for this, especially since the zarr version has not changed compared to some runs that were successful (2.13.6).

@headtr1ck headtr1ck added topic-testing topic-zarr Related to zarr storage library needs triage Issue that has not been reviewed by xarray team member labels Feb 28, 2023
@dcherian dcherian removed the needs triage Issue that has not been reviewed by xarray team member label Feb 28, 2023
@malmans2
Copy link
Contributor

malmans2 commented Mar 1, 2023

The problem comes from libnetcdf. It bumped from 4.8.1 to 4.9.1.
I'll look into it.

@malmans2
Copy link
Contributor

malmans2 commented Mar 1, 2023

See: Unidata/netcdf-c#2647

The problem is that with netcdf-c=4.9.1 dimension names are lost when writing pure nczarr files. We only need it to make sure that xarray is able to read from pure nczarr.

@malmans2
Copy link
Contributor

malmans2 commented Mar 1, 2023

Slightly different issue related to the latest release of netcdf-c.

Looks like nczarr attribute key changed from "_NCZARR_ARRAY" to "_nczarr_array" (see Unidata/netcdf-c#2492), so we would have to take care of this if we want to keep supporting pure nczarr.

os.path.basename(dim) for dim in zarray["_NCZARR_ARRAY"]["dimrefs"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-testing topic-zarr Related to zarr storage library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants