Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SOCKS support to proxy configuration parameter #1674

Closed
cooperlees opened this issue Feb 25, 2024 · 0 comments · Fixed by #1861
Closed

Add SOCKS support to proxy configuration parameter #1674

cooperlees opened this issue Feb 25, 2024 · 0 comments · Fixed by #1861
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@cooperlees
Copy link
Contributor

Doing a docs diff we found that the proxy bandersnatch.conf does not work correctly with SOCKS proxies. Let's tweak the code that checks for SOCKS URLs to check the proxy option in the config as well as the environment variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
1 participant
@cooperlees