Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Return query sequence in get_aligned_pairs #776

Open
y9c opened this issue Mar 23, 2019 · 2 comments
Open

[Feature Request] Return query sequence in get_aligned_pairs #776

y9c opened this issue Mar 23, 2019 · 2 comments

Comments

@y9c
Copy link

y9c commented Mar 23, 2019

get_aligned_pairs(self,  match_only_False, with_ref=True, with_query=True):
    ....

expect output (query_pos, query_seq, ref_pos, ref_seq)

with_seq is a little misleading, and query_seq info is useful for generating per read mutation info. eg T123A for base T at position 123 of ref_seq mutated into A.

@y9c
Copy link
Author

y9c commented Mar 23, 2019

I guest one of the purpose in designing of get_algined_pairs is to show mutation info, because subsitutions are in lower case. But only show the ref_sequence is not sufficient.

@y9c
Copy link
Author

y9c commented Mar 23, 2019

I add the a very simple commit for this feature. It is just work.

  • pysam use looping inside argument checking. To make the code consistent, the code becomes redundant.

  • using two argument is not necessary. It is for backward compatibility.

#777


sorry for wasting such interesting number #777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant