pytest running twisted tests (I think the docs are wrong ;-) )

[cjw296]

From the features list, I see:

• Can run unittest (including trial) test suites out of the box

I'm assuming that "trial" refers to Twisted's trial test runner, but I'm pretty sure pytest doesn't do any of trial's reactor management and https://github.com/pytest-dev/pytest-twisted didn't really do what it needed to when I looked back in 2018.

Is the above bit of the features doc just old and should be deleted?

[The-Compiler]

(Disclaimer: I know nothing about Twisted/trial)

It does look like pytest has various twisted/trial related stuff in its unittest.py support, and that is being tested as well.

I'd say support for other ecosystems always comes with caveats (e.g. back when there still was nose support, it didn't support nose plugins or nose configuration). Going into those in detail seems out of scope for a very basic and short intro page.

I suppose the docs around unittest should maybe be amended to point out what is supported and what's not?

[cjw296]

It does look like pytest has various twisted/trial related stuff

As someone who knows Twisted/trial prettty well, this doesn't do anything useful as soon as you're writing Twisted code. You need a reactor, and you want all the reactor support, cleanup, assertions, etc that trial provides. I'd suggest this stuff is vestigial and should be cleaned up by being deleted ;-)

But certainly worth dropping it from the "features" list as it's misleading.

I suppose the docs around unittest should maybe be amended to point out what is supported and what's not?

The fact that neither Twisted nor trial are even mentioned on that page reinforces my belief...

[RonnyPfannschmidt]

I believe we should limit them to non async twisted tests that dont expect framework support

[cjw296]

@RonnyPfannschmidt, I don't disagree, but I think in that case support should just be removed. How would it be useful to keep tests in Twisted-style UnitTest if they don't do anything async / deferred? In that case, it would surely just be a normal UnitTest subclass?

[RonnyPfannschmidt]

As far as I can tell the support code in pytest specifically target's failure notification extentions of trial

So sync unittests that use trial extensions

Hence my recommendation on documenting this scope limit and the need for a plugin for reactor usage