Skip to content
This repository has been archived by the owner on Nov 2, 2022. It is now read-only.

How should we handle monkeypatching? #2

Open
njsmith opened this issue Oct 8, 2018 · 0 comments
Open

How should we handle monkeypatching? #2

njsmith opened this issue Oct 8, 2018 · 0 comments

Comments

@njsmith
Copy link
Member

njsmith commented Oct 8, 2018

@1st1 has strong feelings (I think) about monkeypatching being something that should be invoked explicitly instead of happening on import. I'm not sure of the concrete rationale in this particular case, where the monkeypatching has zero effect on the semantics of programs that don't use the library.

There is also potentially some complexity if we want to convince projects like sentry to start supporting this library out of the box, because they'll need to the tools to get their sys.excepthook patching and ours to play together properly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant