Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixed conv1d converter when weights are Tensor #2542

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Dec 14, 2023

Description

This PR enables the conv1d -> conv2d converter mapping work when the weights are Tensor.
PS: Kernel tensor is also unsqueezed when the filterDims are unsqueezed for conv1d -> conv2d scenario.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels Dec 14, 2023
@github-actions github-actions bot requested a review from apbose December 14, 2023 23:03
@andi4191
Copy link
Contributor Author

@apbose : I see my PR is breaking in CI. Is the CI broken? I see some torch-tensorrt dependency related issue in the workflow run.

@peri044
Copy link
Collaborator

peri044 commented Dec 18, 2023

@andi4191 There was a problem with CI. I re-triggered it to verify if the latest changes fixed it.

@peri044
Copy link
Collaborator

peri044 commented Dec 20, 2023

@andi4191 Can you rebase your changes and resolve conflicts ?

@andi4191
Copy link
Contributor Author

@andi4191 Can you rebase your changes and resolve conflicts ?

Thanks, I resolved the conflicts. However, I still see CI build failure.

Signed-off-by: Anurag Dixit <[email protected]>
@andi4191 andi4191 force-pushed the anurag.dixit/fix_conv1d branch from e1a2c15 to ee0bb04 Compare December 20, 2023 19:13
@narendasan narendasan requested a review from bowang007 January 12, 2024 19:20
@andi4191
Copy link
Contributor Author

@bowang007 : Is there anything that I can do to merge this PR? Any update on the root cause for CI failure?

@bowang007
Copy link
Collaborator

@bowang007 : Is there anything that I can do to merge this PR? Any update on the root cause for CI failure?

Hi @andi4191 thanks for supporting this.
I think we have removed the CI test for torchscript, correct me if I'm wrong @narendasan.
I'll take a look at this PR tonight and test locally, then I think it should be good to merge.

Thanks!

@andi4191
Copy link
Contributor Author

@bowang007 : Is there anything that I can do to merge this PR? Any update on the root cause for CI failure?

Hi @andi4191 thanks for supporting this. I think we have removed the CI test for torchscript, correct me if I'm wrong @narendasan. I'll take a look at this PR tonight and test locally, then I think it should be good to merge.

Thanks!

Thank you for the update @bowang007

@andi4191
Copy link
Contributor Author

andi4191 commented Feb 2, 2024

Hi @bowang007,

Is this PR good to merge now?

Copy link
Collaborator

@bowang007 bowang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 9a100b6 into pytorch:main Feb 27, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants