Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ExecuTorch] Add broadcast support for optimized add op #8205

Open
wants to merge 1 commit into
base: gh/kimishpatel/154/base
Choose a base branch
from
Open

[ExecuTorch] Add broadcast support for optimized add op #8205

wants to merge 1 commit into from

Conversation

kimishpatel
Copy link
Contributor

@kimishpatel kimishpatel commented Feb 5, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary:
This brings add op to feature parity, wrt, broadcasting, to mul op in
optimized kernels lib

Test Plan:
tests added

Reviewers:

Subscribers:

Tasks:

Tags:

@kimishpatel
[ExecuTorch] Add broadcast support for optimized add op
dbe3e8a 
Summary:
This brings add op to feature parity, wrt, broadcasting, to mul op in
optimized kernels lib

Test Plan:
tests added

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@kimishpatel kimishpatel mentioned this pull request Feb 5, 2025
Open
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8205

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 28 New Failures, 1 Cancelled Job, 2 Unrelated Failures

As of commit dbe3e8a with merge base 6b58e2e (image):

NEW FAILURES - The following jobs have failed:

  • Build documentation / build (buck2) / Build doc (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • Check Labels / Check labels (gh)
    RuntimeError: Error checking labels: PR does not have required labels
  • Lint / lintrunner / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-custom-ops-linux / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-eval_llama-mmlu-linux / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-eval_llama-wikitext-linux / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-llama-runner-linux (bf16, portable) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-llama-runner-linux (fp32, portable) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-llama-runner-linux (fp32, xnnpack+custom) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-llama-runner-linux (fp32, xnnpack+custom+qe) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-llama-runner-linux (fp32, xnnpack+custom+quantize_kv) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-llama-runner-linux (fp32, xnnpack+quantize_kv) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-llama-runner-linux-android / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-llama-runner-qnn-linux (fp32, qnn_8a8w, qnn) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-llava-runner-linux / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-models-linux (buck2, mv3, portable, linux.2xlarge, 90) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-models-linux (buck2, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-models-linux (cmake, mv3, portable, linux.2xlarge, 90) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-models-linux (cmake, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-models-linux (cmake, vit, portable, linux.2xlarge, 90) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-models-linux (cmake, vit, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-phi-3-mini-runner-linux / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-pybind-build-linux / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-quantized-aot-lib-linux / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / test-selective-build-linux / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / unittest / linux / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary
  • pull / unittest-arm / linux-job (gh)
    /pytorch/executorch/../executorch/kernels/optimized/cpu/binary_ops.h:203:41: error: non-const lvalue reference to type 'executorch::aten::optional<Scalar>' (aka 'optional<executorch::runtime::etensor::Scalar>') cannot bind to an initializer list temporary

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kimishpatel added a commit that referenced this pull request Feb 5, 2025
@kimishpatel
[ExecuTorch] Add broadcast support for optimized add op
50b6ce9 
Summary:
This brings add op to feature parity, wrt, broadcasting, to mul op in
optimized kernels lib

Test Plan:
tests added

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e4dea30ccc9b98d26ee028683a87754124e58329
Pull Request resolved: #8205
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kimishpatel kimishpatel mentioned this pull request Feb 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimishpatel @facebook-github-bot