GeneratorArgs.is_torchtune_model is a misnomer #1273
Labels
actionable
Items in the backlog waiting for an appropriate impl/fix
good first issue
Good for newcomers
🚀 The feature, motivation and pitch
is_torchtune_model
is a misnomer and can result in buggy code. It gates logic for models that havetune
suffix, but not all torchtune models end with this suffix. For example Flamingo (Llama3.2 11B) is also a torchtune modelThis results in code like this:
torchchat/torchchat/generate.py
Lines 611 to 614 in d0993b3
Alternatives
No response
Additional context
No response
RFC (Optional)
While the logic around torchtune models itself needs some refactor, the short term solution is some combination of:
tune
The text was updated successfully, but these errors were encountered: