Write tests

[ashwini0529]

No tests have been written as of now. Writing tests would be very helpful.

[Emanon42]

Looks fun! But how can I write unit test for random generator (forgive my innocence, I am new to python)?

[ashwini0529]

There're other functions as well. Please have a look at other modules as well. :)

[theycallmemac]

Do you specifically want tests for each feature offered as described in the README.md file? If so, I'll take this on.

[ashwini0529]

Yes, that would be great. All the functions present in the library.

[theycallmemac]

No problem, you can assign this to me so.

[ashwini0529]

Sure thing! 👍

[e-zorzi]

if it's not a problem I started writing some tests, I didn't see @theycallmemac post here

[ashwini0529]

@theycallmemac are you still working on this issue?

[theycallmemac]

I am, but I'll let @edo-vi work away, if they aren't sufficient, let me know and I'll see what I can do! best of luck

[ashwini0529]

@theycallmemac meanwhile you can check #8 😄

[samuelrey]

It may be worth considering to specify which function you'll test as well as the cases they cover. That way multiple contributors could work on tests & the pull request will be one, cohesive iteration.

[samuelrey]

I noticed that between #14 and #33 that the tests live in different places. Was this intentional? Could we move them to the same place?

[samuelrey]

I am testing ipv4 & ipv6!

[ashwini0529]

@samuelrey That was unintentional.
Can you please put all the tests to a single path? Also, tests need to be uniform.

[samuelrey]

Gotcha!

[samuelrey]

What version of python should we be targeting?

[ashwini0529]

Upto 3

[theycallmemac]

Has anything been done on this?

[samuelrey]

I lost my local changes D:
Will update you on Saturday!

[shubhodeep9]

Closing this issue,
Any discussions regarding tests, let's move it to #51