-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orix 0.13.1 Causes Test Failure in Pyxem #526
Comments
If you can wait until Saturday I can have a look. Seems like some inconsistency in the calculation of misorientation angle from 0.13.0 to 0.13.1. |
The test is too complicated for me to debug. I don't know what the variables |
@hakonanes no worries, I'll look into on Monday and I can track down the change there :) I was just thinking you might have a quick idea for what changed |
Unfortunately not. We didn't have to update any misorientation angle tests when making numpy-quaternion an optional dependency. So I didn't expect this to be a problem... |
From highly related #539:
Me:
|
Describe the bug
It seems like orix 0.13.1 causes a test failure in the orientation mapping code. (see the action: https://github.com/pyxem/pyxem/actions/runs/11052306498/job/30704105695)
It might be just a trivial example of equivilent orientations or some small change there. I haven't looked at it in too much detail. @hakonanes if you have an idea off the top of your head that might cause that change that might be helpful otherwise I can look into it.
The text was updated successfully, but these errors were encountered: