Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor notifications with toasts and modals #799

Open
10 of 28 tasks
sven1103 opened this issue Aug 20, 2024 · 4 comments
Open
10 of 28 tasks

Refactor notifications with toasts and modals #799

sven1103 opened this issue Aug 20, 2024 · 4 comments
Assignees
Labels
core Feature or fix task considered to be in the core product enhancement New feature or request triage An issue that is in discussion to be either scheduled for implepmentation or denied

Comments

@sven1103
Copy link
Contributor

sven1103 commented Aug 20, 2024

What are you missing?

Success notifications (Toasts)

Usage: Triggered after successful completion of each task

  • Project creation and editing
  • Experiment creation and editing
  • Experimental variables creation and editing
  • Experimental groups creation and editing
  • Offer upload and remove
  • QC upload and remove
  • PAT token creation, copying and deletion
  • Project Access person add and remove (also email notifications for the same)
  • Show toast on Sample batch add, update, remove #973
  • Sample batch dialog add, remove row
  • Show toast on measurement interaction #977
  • Measurements - RAW data available

Warning notifications (Dialogs)

Usage: To warn the user of potential risks that may arise during an interaction.

  • Confirmation msgs on delete Sample batch
  • Confirmation msgs on delete PAT
  • Confirmation msgs on delete measurement

Information notifications (Dialogs)
Confirmation msg on dialog cancellation

  • cancel project creation
  • cancel project editing
  • cancel experiment creation
  • cancel experiment editing
  • cancel exp. variable creation
  • cancel exp. variable editing
  • cancel sample batch registration
  • PAT copy
  • TSV conversion in dialogs (Register and Edit measurements)

Error Notifications

Usage: To inform users of critical issues and guide them to resolution.

  • File upload : exceeding size, improper TSV, technical errors (DB, network, etc)
  • Editing experiment design after samples are registered.
  • Deleting measurements when no item is selected.

Why do you need a solution?

Depends on #682

Ideas

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@sven1103 sven1103 added enhancement New feature or request triage An issue that is in discussion to be either scheduled for implepmentation or denied labels Aug 20, 2024
@sven1103 sven1103 added core Feature or fix task considered to be in the core product and removed triage An issue that is in discussion to be either scheduled for implepmentation or denied labels Aug 20, 2024
@sven1103 sven1103 removed this from Issue triage Aug 20, 2024
@sven1103 sven1103 moved this to Todo in Sprint Planning Aug 20, 2024
@sven1103 sven1103 pinned this issue Aug 22, 2024
@wow-such-code
Copy link
Member

Is cancel confirmation for experimental groups missing by design?

@Shraddha0903
Copy link
Contributor

Shraddha0903 commented Sep 5, 2024

Is cancel confirmation for experimental groups missing by design?

@wow-such-code Yes, we don't have the cancel confirmation for the experimental groups by design as imo the accidental action of the Cancel button is not potentially as harmful as the others. The lost information could cost the users not more than a few minutes to reenter compared to the increased amount of clicks caused by the cancel confirmation that would annoy them.
We should keep them only for the dialogs where the action could be destructive and would cost some time and effort to the user. We should also remove it for the sample batch registration dialog, as there won't be the spreadsheet component anymore.

Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Oct 16, 2024
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Sprint Planning Nov 16, 2024
@sven1103 sven1103 reopened this Feb 11, 2025
@sven1103 sven1103 removed the stale label Feb 11, 2025
@github-actions github-actions bot added the triage An issue that is in discussion to be either scheduled for implepmentation or denied label Feb 11, 2025
@sven1103 sven1103 moved this from Done to Todo in Sprint Planning Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Feature or fix task considered to be in the core product enhancement New feature or request triage An issue that is in discussion to be either scheduled for implepmentation or denied
Projects
Status: No status
Status: Todo
Development

No branches or pull requests

3 participants