From 9f773aa96be6ae02acd56da2a5295b71247475dd Mon Sep 17 00:00:00 2001
From: Withalion <matej.bagar@lutraconsulting.co.uk>
Date: Wed, 18 Dec 2024 12:05:36 +0100
Subject: [PATCH] Fix to more descriptive test data naming

---
 tests/src/app/testqgsidentify.cpp                   |   2 +-
 .../python/test_qgspointcloudclassifiedrenderer.py  |   2 +-
 ...laz => combined-with-overview-overview.copc.laz} | Bin
 ...{new-combined.vpc => combined-with-overview.vpc} |   8 ++++----
 4 files changed, 6 insertions(+), 6 deletions(-)
 rename tests/testdata/point_clouds/virtual/sunshine-coast/{new-combined-overview.copc.laz => combined-with-overview-overview.copc.laz} (100%)
 rename tests/testdata/point_clouds/virtual/sunshine-coast/{new-combined.vpc => combined-with-overview.vpc} (98%)

diff --git a/tests/src/app/testqgsidentify.cpp b/tests/src/app/testqgsidentify.cpp
index d2c79719d86b..3133da33b080 100644
--- a/tests/src/app/testqgsidentify.cpp
+++ b/tests/src/app/testqgsidentify.cpp
@@ -1301,7 +1301,7 @@ void TestQgsIdentify::identifyPointCloud()
 void TestQgsIdentify::identifyVirtualPointCloud()
 {
 #ifdef HAVE_COPC
-  std::unique_ptr<QgsPointCloudLayer> pointCloud = std::make_unique<QgsPointCloudLayer>( QStringLiteral( TEST_DATA_DIR ) + "/point_clouds/virtual/sunshine-coast/new-combined.vpc", QStringLiteral( "pointcloud" ), QStringLiteral( "vpc" ) );
+  std::unique_ptr<QgsPointCloudLayer> pointCloud = std::make_unique<QgsPointCloudLayer>( QStringLiteral( TEST_DATA_DIR ) + "/point_clouds/virtual/sunshine-coast/combined-with-overview.vpc", QStringLiteral( "pointcloud" ), QStringLiteral( "vpc" ) );
   QVERIFY( pointCloud->isValid() );
   pointCloud->setCrs( QgsCoordinateReferenceSystem( QStringLiteral( "EPSG:28356" ) ) );
   QCOMPARE( pointCloud->crs3D().horizontalCrs().authid(), QStringLiteral( "EPSG:28356" ) );
diff --git a/tests/src/python/test_qgspointcloudclassifiedrenderer.py b/tests/src/python/test_qgspointcloudclassifiedrenderer.py
index 373b2111dc21..d1f882004b6f 100644
--- a/tests/src/python/test_qgspointcloudclassifiedrenderer.py
+++ b/tests/src/python/test_qgspointcloudclassifiedrenderer.py
@@ -475,7 +475,7 @@ def testRenderTriangles(self):
     def testOverviewRender(self):
         layer = QgsPointCloudLayer(
             unitTestDataPath()
-            + "/point_clouds/virtual/sunshine-coast/new-combined.vpc",
+            + "/point_clouds/virtual/sunshine-coast/combined-with-overview.vpc",
             "test",
             "vpc",
         )
diff --git a/tests/testdata/point_clouds/virtual/sunshine-coast/new-combined-overview.copc.laz b/tests/testdata/point_clouds/virtual/sunshine-coast/combined-with-overview-overview.copc.laz
similarity index 100%
rename from tests/testdata/point_clouds/virtual/sunshine-coast/new-combined-overview.copc.laz
rename to tests/testdata/point_clouds/virtual/sunshine-coast/combined-with-overview-overview.copc.laz
diff --git a/tests/testdata/point_clouds/virtual/sunshine-coast/new-combined.vpc b/tests/testdata/point_clouds/virtual/sunshine-coast/combined-with-overview.vpc
similarity index 98%
rename from tests/testdata/point_clouds/virtual/sunshine-coast/new-combined.vpc
rename to tests/testdata/point_clouds/virtual/sunshine-coast/combined-with-overview.vpc
index f1aaded4407e..054337c51212 100644
--- a/tests/testdata/point_clouds/virtual/sunshine-coast/new-combined.vpc
+++ b/tests/testdata/point_clouds/virtual/sunshine-coast/combined-with-overview.vpc
@@ -212,7 +212,7 @@
           ]
         },
         "overview": {
-          "href": "./new-combined-overview.copc.laz",
+          "href": "./combined-with-overview-overview.copc.laz",
           "roles": [
             "overview"
           ]
@@ -430,7 +430,7 @@
           ]
         },
         "overview": {
-          "href": "./new-combined-overview.copc.laz",
+          "href": "./combined-with-overview-overview.copc.laz",
           "roles": [
             "overview"
           ]
@@ -648,7 +648,7 @@
           ]
         },
         "overview": {
-          "href": "./new-combined-overview.copc.laz",
+          "href": "./combined-with-overview-overview.copc.laz",
           "roles": [
             "overview"
           ]
@@ -866,7 +866,7 @@
           ]
         },
         "overview": {
-          "href": "./new-combined-overview.copc.laz",
+          "href": "./combined-with-overview-overview.copc.laz",
           "roles": [
             "overview"
           ]