From a4c5395295a534ea237d836105f692c794a3c418 Mon Sep 17 00:00:00 2001
From: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri, 24 Jan 2025 15:11:59 +1000
Subject: [PATCH] Use standard functions for writing/reading enum class values

---
 src/core/mesh/qgsmeshrenderersettings.cpp | 60 ++---------------------
 src/core/mesh/qgsmeshrenderersettings.h   | 13 -----
 2 files changed, 4 insertions(+), 69 deletions(-)

diff --git a/src/core/mesh/qgsmeshrenderersettings.cpp b/src/core/mesh/qgsmeshrenderersettings.cpp
index 6930308ff8e8..cd2956944b68 100644
--- a/src/core/mesh/qgsmeshrenderersettings.cpp
+++ b/src/core/mesh/qgsmeshrenderersettings.cpp
@@ -134,9 +134,9 @@ QDomElement QgsMeshRendererScalarSettings::writeXml( QDomDocument &doc, const Qg
   elem.setAttribute( QStringLiteral( "interpolation-method" ), methodTxt );
 
   if ( mRangeExtent != Qgis::MeshRangeExtent::WholeMesh )
-    elem.setAttribute( QStringLiteral( "range-extent" ), QgsMeshRendererScalarSettings::extentString( mRangeExtent ) );
+    elem.setAttribute( QStringLiteral( "range-extent" ), qgsEnumValueToKey( mRangeExtent ) );
   if ( mRangeLimit != Qgis::MeshRangeLimit::NotSet )
-    elem.setAttribute( QStringLiteral( "range-limit" ), QgsMeshRendererScalarSettings::limitsString( mRangeLimit ) );
+    elem.setAttribute( QStringLiteral( "range-limit" ), qgsEnumValueToKey( mRangeLimit ) );
 
   const QDomElement elemShader = mColorRampShader.writeXml( doc, context );
   elem.appendChild( elemShader );
@@ -165,8 +165,8 @@ void QgsMeshRendererScalarSettings::readXml( const QDomElement &elem, const QgsR
     mDataResamplingMethod = DataResamplingMethod::NoResampling;
   }
 
-  mRangeExtent = QgsMeshRendererScalarSettings::extentFromString( elem.attribute( "range-extent" ) );
-  mRangeLimit = QgsMeshRendererScalarSettings::limitsFromString( elem.attribute( "range-limit" ) );
+  mRangeExtent = qgsEnumKeyToValue( elem.attribute( "range-extent" ), Qgis::MeshRangeExtent::WholeMesh );
+  mRangeLimit = qgsEnumKeyToValue( elem.attribute( "range-limit" ), Qgis::MeshRangeLimit::NotSet );
 
   const QDomElement elemShader = elem.firstChildElement( QStringLiteral( "colorrampshader" ) );
   mColorRampShader.readXml( elemShader, context );
@@ -208,58 +208,6 @@ void QgsMeshRendererScalarSettings::updateShader()
     mColorRampShader.classifyColorRamp( mColorRampShader.sourceColorRamp()->count(), 1, QgsRectangle(), nullptr );
 }
 
-QString QgsMeshRendererScalarSettings::extentString( Qgis::MeshRangeExtent extent )
-{
-  switch ( extent )
-  {
-    case Qgis::MeshRangeExtent::WholeMesh:
-      return QStringLiteral( "WholeMesh" );
-    case Qgis::MeshRangeExtent::FixedCanvas:
-      return QStringLiteral( "CurrentCanvas" );
-    case Qgis::MeshRangeExtent::UpdatedCanvas:
-      return QStringLiteral( "UpdatedCanvas" );
-  }
-  return QStringLiteral( "WholeMesh" );
-}
-
-Qgis::MeshRangeExtent QgsMeshRendererScalarSettings::extentFromString( const QString &extent )
-{
-  if ( extent == QLatin1String( "WholeMesh" ) )
-  {
-    return Qgis::MeshRangeExtent::WholeMesh;
-  }
-  else if ( extent == QLatin1String( "CurrentCanvas" ) )
-  {
-    return Qgis::MeshRangeExtent::FixedCanvas;
-  }
-  else if ( extent == QLatin1String( "UpdatedCanvas" ) )
-  {
-    return Qgis::MeshRangeExtent::UpdatedCanvas;
-  }
-
-  return Qgis::MeshRangeExtent::WholeMesh;
-}
-
-QString QgsMeshRendererScalarSettings::limitsString( Qgis::MeshRangeLimit limits )
-{
-  switch ( limits )
-  {
-    case Qgis::MeshRangeLimit::MinimumMaximum:
-      return QStringLiteral( "MinMax" );
-    default:
-      break;
-  }
-  return QStringLiteral( "None" );
-}
-
-Qgis::MeshRangeLimit QgsMeshRendererScalarSettings::limitsFromString( const QString &limits )
-{
-  if ( limits == QLatin1String( "MinMax" ) )
-  {
-    return Qgis::MeshRangeLimit::MinimumMaximum;
-  }
-  return Qgis::MeshRangeLimit::NotSet;
-}
 
 // ---------------------------------------------------------------------
 
diff --git a/src/core/mesh/qgsmeshrenderersettings.h b/src/core/mesh/qgsmeshrenderersettings.h
index b59664628204..3c4ae1045e9c 100644
--- a/src/core/mesh/qgsmeshrenderersettings.h
+++ b/src/core/mesh/qgsmeshrenderersettings.h
@@ -211,19 +211,6 @@ class CORE_EXPORT QgsMeshRendererScalarSettings
   private:
     void updateShader();
 
-    //! Returns a string to serialize Limits
-    static QString limitsString( Qgis::MeshRangeLimit limits );
-
-    //! \brief Deserialize Limits
-    static Qgis::MeshRangeLimit limitsFromString( const QString &limits );
-
-    //! Returns a string to serialize Extent
-    static QString extentString( Qgis::MeshRangeExtent extent );
-
-    //! \brief Deserialize Extent
-    static Qgis::MeshRangeExtent extentFromString( const QString &extent );
-
-
     QgsColorRampShader mColorRampShader;
     DataResamplingMethod mDataResamplingMethod = DataResamplingMethod::NoResampling;
     double mClassificationMinimum = 0;