You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Usually this is not a problem, since the import only happens at runtime through a dedicate path-based mechanism (cf. create_platform). However, it becomes an issue for any direct manipulation, e.g. creating the parameters from scratch, through the support introduced in #1123.
It may definitely be worth to favor a new name (e.g. create.py, or whatever else).
Breaking change
While imposing a new name would be a breaking change, we could immediately start transitioning allowing an extra name, just leaving the old name deprecation to the next breaking release.
The text was updated successfully, but these errors were encountered:
Qibolab requires a platform folder to contain a
platform.py
file.While this is a meaningful name, it is also pretty inconvenient, since clashing with the standard library.
https://docs.python.org/3/library/platform.html
Usually this is not a problem, since the import only happens at runtime through a dedicate path-based mechanism (cf.
create_platform
). However, it becomes an issue for any direct manipulation, e.g. creating the parameters from scratch, through the support introduced in #1123.It may definitely be worth to favor a new name (e.g.
create.py
, or whatever else).Breaking change
While imposing a new name would be a breaking change, we could immediately start transitioning allowing an extra name, just leaving the old name deprecation to the next breaking release.
The text was updated successfully, but these errors were encountered: