Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split analysis and tests #31

Open
alecandido opened this issue Feb 7, 2023 · 2 comments
Open

Split analysis and tests #31

alecandido opened this issue Feb 7, 2023 · 2 comments
Assignees

Comments

@alecandido
Copy link
Member

Sometimes Pylint errors are preventing the whole unit tests to run, possibly hiding some further failures.

While in principle it is fine to have a reasonable code before testing, whenever there are Pylint errors are usually localized to some small portions of the code, and they would not cause the whole unit tests to fail.

I propose to make the two jobs independent, even keeping them inside a single workflow. Moreover, we do not need to run Pylint on all the combinations of matrix on which we run unit tests, it is sufficient to iterate Python versions, while linting errors should not depend on the os/architecture.

@alecandido alecandido self-assigned this Feb 7, 2023
@alecandido
Copy link
Member Author

@scarrazza before starting I'd like to have your opinion.

@scarrazza
Copy link
Member

The idea of splitting, looks sensible to me, so you have my endorsement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🆕 New
Development

No branches or pull requests

2 participants