Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to np.random.* for test utils #35

Open
jamesETsmith opened this issue Sep 25, 2024 · 0 comments
Open

Revert back to np.random.* for test utils #35

jamesETsmith opened this issue Sep 25, 2024 · 0 comments

Comments

@jamesETsmith
Copy link
Contributor

General

Early on in development we steered away from np.random.* functions because best practice for truly reproducible results is to instantiation your own RNG and carry it around. In my opinion, we do not need need this level of stringent reproducibility in the test framework and the global state problems are not present when testing.

See this post on from the Numpy devs here.

This is something that should wait until after the initial release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant