Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aeromancy configuration should live in pyproject.toml #18

Open
dmcc opened this issue Jul 19, 2024 · 0 comments
Open

Aeromancy configuration should live in pyproject.toml #18

dmcc opened this issue Jul 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dmcc
Copy link
Collaborator

dmcc commented Jul 19, 2024

There's lots of Aeromancy customization which needs to live somewhere. We currently do it by baking in command line arguments to the pdm go script, but much could be specified more cleanly in pyproject.toml. This includes --extra-docker-run-args, --extra-env-var, etc.

And potential new features like:

Aeromancy already uses the tomli package (which seems to be API-compatible with newer stdlib tomllib), so that might be an easy way to get this in.

One question is how to combine TOML configuration with command-line flags. In general, I think they should be additive, though for flags that set command line arguments (e.g., --extra-docker-run-args), we might want to ensure that they're only set in one place and raise an error otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant