Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation for MCP Client properties #1252

Closed
kdubois opened this issue Jan 28, 2025 · 2 comments · Fixed by #1254
Closed

Better documentation for MCP Client properties #1252

kdubois opened this issue Jan 28, 2025 · 2 comments · Fixed by #1254
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@kdubois
Copy link

kdubois commented Jan 28, 2025

Related to #1249 I was trying to get an example MCP sse server + client up and running but it was pretty hard to figure out how to configure the app because I couldn't find an exhaustive list of MCP client properties on https://docs.quarkiverse.io/quarkus-langchain4j/dev/mcp.html . Can we add a bit more documentation on how to use it and add a list of config properties ?

@geoand geoand added the documentation Improvements or additions to documentation label Jan 28, 2025
@jmartisk
Copy link
Collaborator

Ah, we could add a configuration reference like we have in other parts of the doc, right. That would be a good start.

Note that I don't intend to duplicate too much stuff from the langchain4j documentation (https://docs.langchain4j.dev/tutorials/mcp/) so that's why the quarkus documentation contains a link to that one, the user may have to look there too.

@kdubois
Copy link
Author

kdubois commented Jan 28, 2025

Ok yeah that makes sense, that way there's less risk of things getting outdated vs the langchain4j docs. As long as the quarkus docs have the config reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants