Add validation when the input-base-dir is not present #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcruzdev
force-pushed
the
issue-871
branch
2 times, most recently
from
a700976 to
b9a8d5e
Compare
ricardozanini
approved these changes
Jan 6, 2025
hbelmiro
reviewed
Jan 19, 2025
| @@ -60,4 +61,14 @@ public void testInputDir() throws CodeGenException { | |||
| Path.of("target/generated-test-sources/inputDir/io/petstore/PetResource.java"))); | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldGenerateAnErrorWhenInputDirIsNotExist() throws CodeGenException { | |||
There was a problem hiding this comment.
Suggested change
| public void shouldGenerateAnErrorWhenInputDirIsNotExist() throws CodeGenException { | |
| public void shouldGenerateAnErrorWhenInputDirIsNotExist() { |
| private static void validateOpenApiDir(CodeGenContext context, Path openApiDir) throws CodeGenException { | ||
| if (!Files.exists(openApiDir)) { | ||
| throw new CodeGenException( | ||
| "The OpenAPI input base directory does not exist, please, create the directory on " + context.inputDir()); |
There was a problem hiding this comment.
Suggested change
| "The OpenAPI input base directory does not exist, please, create the directory on " + context.inputDir()); | |
| "The OpenAPI input base directory does not exist. Please create the directory at " + context.inputDir()); |
|
|
||
| if (!Files.isDirectory(openApiDir)) { | ||
| throw new CodeGenException( | ||
| "The OpenAPI input base directory is not a directory, please, create the directory on " |
There was a problem hiding this comment.
Suggested change
| "The OpenAPI input base directory is not a directory, please, create the directory on " | |
| "The OpenAPI input base directory is not a directory. Please create the directory at " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Fixes #871
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectI am not sure if this pull request solves the issue, but I think that shows a better message.
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.