Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #940 - Change authorization properties configuration to RUNTIME #943

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix #940 - Change authorization properties configuration to RUNTIME #943

wants to merge 5 commits into from
+2,193 −218

Conversation

ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Jan 17, 2025 •
edited
Loading

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

Closes #940

WIP:

  • - Review unit test in runtime module to use QuarkusTestProfile
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ricardozanini ricardozanini mentioned this pull request Jan 17, 2025
Open
@ricardozanini ricardozanini added area:client This item is related to the client extension backport-main-lts labels Jan 17, 2025
@ricardozanini
Copy link
Member Author

cc @quarkiverse/quarkiverse-openapi-generator

@ricardozanini ricardozanini marked this pull request as ready for review January 17, 2025 23:21
@ricardozanini ricardozanini requested a review from a team as a code owner January 17, 2025 23:21
@ricardozanini ricardozanini changed the title Fix #940 - Change authorization properties configuration to RUNTIME WIP - Fix #940 - Change authorization properties configuration to RUNTIME Jan 17, 2025
@ricardozanini ricardozanini mentioned this pull request Jan 20, 2025
Open
7 tasks
@ricardozanini ricardozanini changed the title WIP - Fix #940 - Change authorization properties configuration to RUNTIME Fix #940 - Change authorization properties configuration to RUNTIME Jan 20, 2025
@ricardozanini
Incorporating @mcruzdev's review
1114573 
Signed-off-by: Ricardo Zanini <[email protected]>
hbelmiro
hbelmiro approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Just 2 nits.

...rc/test/java/io/quarkiverse/openapi/generator/providers/AbstractOpenApiSpecProviderTest.java Outdated Show resolved Hide resolved
.../src/test/java/io/quarkiverse/openapi/generator/providers/BearerOpenApiSpecProviderTest.java Show resolved Hide resolved
@ricardozanini
incorporating @hbelmiro's review
d9a6ed9 
Signed-off-by: Ricardo Zanini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcruzdev mcruzdev mcruzdev approved these changes

@hbelmiro hbelmiro hbelmiro approved these changes

@rmanibus rmanibus Awaiting requested review from rmanibus

@fjtirado fjtirado Awaiting requested review from fjtirado

Assignees
No one assigned
Labels
area:client This item is related to the client extension backport-main-lts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration can't be updated at runtime
3 participants
@ricardozanini @hbelmiro @mcruzdev