Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration can't be updated at runtime #940

Open
nullptr0000 opened this issue Jan 17, 2025 · 2 comments · May be fixed by #943
Open

Configuration can't be updated at runtime #940

nullptr0000 opened this issue Jan 17, 2025 · 2 comments · May be fixed by #943
Assignees
Labels
area:client This item is related to the client extension bug Something isn't working

Comments

@nullptr0000
Copy link

As an apparent side effect of #797 and #795 the ability to configure authentication appears severely limited.

The configuration of authentication has changed to BUILD_AND_RUNTIME_FIXED instead of RUN_TIME. This appears to have the side effect (for example) of preventing the Quarkus Kubernetes Config methods being used to set or override values from K8S ConfigMaps or Secrets, and presumably breaks other production solutions invoked at runtime too eg. Vault.

I suspect the change also affects the ability to configure authentication values using system & environment properties for native builds, though this does still work OK for jar builds.

Setting certain configuration properties at build isn't necessarily an issue even if it's potentially inflexible, but deployment specific dynamic values (at minimum usernames/passwords/other identifiers) should always be configurable at runtime.

Either the authentication configuration should revert to runtime from build time or the configuration properties should be split into runtime and build time depending on their effect, in line with the methodology of other Quarkus components.

@ricardozanini
Copy link
Member

cc @rmanibus

@ricardozanini ricardozanini self-assigned this Jan 17, 2025
@ricardozanini ricardozanini added bug Something isn't working area:client This item is related to the client extension labels Jan 17, 2025
ricardozanini added a commit to ricardozanini/quarkus-openapi-generator that referenced this issue Jan 17, 2025
@ricardozanini
Copy link
Member

@nullptr0000 can you please give it a try on this PR? #943

It's in the draft stage; I must fix the runtime unit tests and add or modify a few integration tests. Please test it on your end and provide me with feedback.

ricardozanini added a commit to ricardozanini/quarkus-openapi-generator that referenced this issue Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:client This item is related to the client extension bug Something isn't working
Projects
None yet
2 participants