Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging configuration for specific declarative RestClient using named properties #45519

Closed
lasteris opened this issue Jan 11, 2025 · 3 comments · Fixed by #45520
Closed

Logging configuration for specific declarative RestClient using named properties #45519

lasteris opened this issue Jan 11, 2025 · 3 comments · Fixed by #45520
Labels
area/arc Issue related to ARC (dependency injection) area/config area/rest-client kind/enhancement New feature or request
Milestone

Comments

@lasteris
Copy link
Contributor

lasteris commented Jan 11, 2025

Description

For now, if you define a bunch of Rest Clients via @RegisterRestClient and configure it all through application.properties, you're still limited with global logging configuration properties:

quarkus.rest-client.logging.scope=request-response
quarkus.rest-client.logging.body-limit=50

quarkus.log.category."org.jboss.resteasy.reactive.client.logging".level=DEBUG

My idea is just simple enhancement by using named clients:

quarkus.rest-client.client3.logging.scope=all
quarkus.rest-client.client3.logging.body-limit=50000

Implementation ideas

Also, I created reproducer project (https://github.com/lasteris/rest-client-logging), which using new properties

@lasteris lasteris added the kind/enhancement New feature or request label Jan 11, 2025
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/config area/rest-client labels Jan 11, 2025
Copy link

quarkus-bot bot commented Jan 11, 2025

/cc @Ladicek (arc), @cescoffier (rest-client), @geoand (rest-client), @manovotn (arc), @mkouba (arc), @radcortez (config)

@lasteris
Copy link
Contributor Author

@geoand Maybe we should rename the title ? Replace "particular cdi-one" to "specific declarative client" ?

@geoand
Copy link
Contributor

geoand commented Jan 14, 2025

Sure, go ahead :)

@lasteris lasteris changed the title Rest Client logging configuration per particular CDI-one via application.properties Logging configuration for specific declarative RestClient using named properties Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/config area/rest-client kind/enhancement New feature or request
Projects
None yet
2 participants