Enable copy assignment operator for iterator class
#389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h-vetinari I am expecting this to fix your conda issues! I can't test though, so if you can do so, that would be appreciated. |
This re-enables the copy assignment operator that was implicitly deleted for the `iterator` class, and also cleans some things up since we don't need the duplicate `data_` reference
It seems that the toolchain on 3.6 Windows did not have these implemented yet
DavisVaughan
force-pushed
the
feature/copy-assignment-writable-iterator
branch
from
3340550 to
efa7733
Compare
|
Tested in conda-forge/r-arrow-feedstock#94 using conda-forge/r-cpp11-feedstock#27, and it works! 🥳 Thank you very much! Looking forward to 0.4.8! |
|
Awesome! |
Is there any timeline for this? :) |
|
It's on cran |
|
Ah, I was looking at the git tags in repo here and didn't see anything past 0.4.7. Would still be good to tag the versions you release IMO. 🙃 Thanks for the quick response! |
|
Woops i normally do. Added now https://github.com/r-lib/cpp11/releases/tag/v0.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #360
Closes #334
Expands on 686ae04 to carry over some of these changes to
iteratoras well (i.e., not justconst_iterator). Note that I have not changediteratorto be arandom_access_iterator_tag, I left it as aforward_iterator_tag. Making a random access iterator requires many extra methods. I don't even think we implement all of them forconst_iterator. I've added some comments about that and if we have issues in the future with iterators we should look and see if we just need more methods.