-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We're unable to build in Release mode but you have a change on master
that fixes the issue
#21
Comments
Oh, it looks like It's not just me that has experienced this issue then! I have found a working solution to this, which is simply adding a namespace to the Collection type. I'm assuming whatever changes that went to the latest Swift compiler prevent it from making sense of this particular generic constraint. Changing this:
into:
has resolved this issue for me (for both Debug and Release scheme). I'm happy to provide a PR that fixes this. |
The change to fix this is already on the For now, we've resolved it in our app by depending directly on the |
Noted, I've been using my own fork for a while and I haven't noticed changes to the master branch - hopefully a release will follow. |
+1 any news on releasing master @craigomac ? |
Sorry for everyone, I completely forget to make a new release 🙏 |
new tag and pod released. |
Yes, I used
but
is required to detect new version. Otherwise I was getting error:
|
Checklist
Expected Behavior
We should be able to build in Release mode.
Current Behavior
In Xcode 11.4 only, building the framework in Release mode fails. The error is in
SnapshotStructure.swift
on line 38: the compiler complains that it resolvesCollection
toSnapshotStructure.Section.Collection
and that this type has no associatedElement
.Detailed Description (Include Screenshots)
The change already made on
master
toSwift.Collection
resolves this issue, but it's not yet in a release.Please can you make a new release including this change?
Environment
version:
Swift version:
5.0
12.1/13.4
11.4
Any
1.9.0.beta.2 (issue also occurs with latest SPM release)
The text was updated successfully, but these errors were encountered: