chore(ci): Configure eslint in CI #9
Draft
+47
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Run `next lint` on pull requests
hairmare
force-pushed
the
chore/eslint-configuration
branch
from
5b88139 to
650fbc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure eslint to run against the code. Based on the Next.JS reference configuration.
eslintdoes static testing, it's raison d'être is to ensure that the quality of code matches what can be reasonably expected from a modern next application. This improves the security, readability, and maintainability of the code.Since the
next/folder was initialized with typescript support, we configure eslint for typescript.note: A high amount of eslint complaints is expected when initially adopting eslint. Most likely they consist of a ton of low hanging fruit that can be easily auto-fixed.