Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use timer to send join #12

Closed
raedah opened this issue May 22, 2018 · 4 comments
Closed

Use timer to send join #12

raedah opened this issue May 22, 2018 · 4 comments

Comments

@raedah
Copy link
Member

raedah commented May 22, 2018

Delete the maxparticipants option in dcrtxmatcher, and instead set a send timer that will cause the joined splittx to be sent every x minutes. This way the joins will happen for any number of participants.
@huyntsgs
Copy link
Contributor

huyntsgs commented May 31, 2018 •
edited
Loading

Should keep maxparticipants to control max participants can join in and combine with timer, which condition is met first then joining will be processed. Too much participants in one split tx looks like not nice

@huyntsgs
Copy link
Contributor

huyntsgs commented May 31, 2018 •
edited
Loading

Fixed in this commit 8ce2455, 0a49ea1 and https://github.com/raedahgroup/dcrwallet/commit/5db3d8ff354b38372ad743e6b9cf54092cdfd061

@raedah
Copy link
Member Author

raedah commented Jun 2, 2018

More participants = better privacy

@raedah
Copy link
Member Author

raedah commented Jun 2, 2018

verified working

@raedah raedah closed this as completed Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huyntsgs @raedah